Open oytunistrator opened 5 years ago
Same issue here.
same here
What about the other install method?
curl -sL https://raw.githubusercontent.com/slap-editor/slap/master/install.sh | sh
It worked on Ubuntu 18.04 (npm
must still be installed).
same;
# Installing slap...
/usr/local/bin/slap -> /usr/local/lib/node_modules/slap/slap.js
> marker-index@4.0.0 install /usr/local/lib/node_modules/slap/node_modules/marker-index
> node-gyp rebuild
gyp WARN EACCES user "root" does not have permission to access the dev dir "/home/oytun/.node-gyp/8.11.4"
gyp WARN EACCES attempting to reinstall using temporary dev dir "/usr/local/lib/node_modules/slap/node_modules/marker-index/.node-gyp"
gyp WARN install got an error, rolling back install
gyp WARN install got an error, rolling back install
gyp ERR! configure error
gyp ERR! stack Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules/slap/node_modules/marker-index/.node-gyp'
gyp ERR! System Linux 4.18.0-17-generic
gyp ERR! command "/usr/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/local/lib/node_modules/slap/node_modules/marker-index
gyp ERR! node -v v8.11.4
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! marker-index@4.0.0 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the marker-index@4.0.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/oytun/.npm/_logs/2019-04-18T19_53_25_940Z-debug.log
The problem is with text-buffer dependency and node-inspector (dev-dependency). I upgraded everything to latest (in three projects slap, editor-widget, base-widget)
https://github.com/cancerberoSgx/slap
It currently doesn't work with node 12 so you have to use 11 or and it works with node.js 11 or older (it currently doesn't work with node.js 12 - working on that), so these are instructions to use nave
node version manager (you could use nvm, n etc):
npm i nave
npx nave use 11
npm i cancerberosgx/slap
npx slap .
@nateGeorge that also won't work. The only thing it seems to work is to downgrade to node 6.x and compile with that..
The problem is with text-buffer dependency and node-inspector (dev-dependency). I upgraded everything to latest (in three projects slap, editor-widget, base-widget) and it compiled without problems. using latest node.
After small incompatibilities fixed have it working with latest dependencies and node version: https://github.com/cancerberoSgx/slap
For installing globally the following should work:
npm i -g git+https://github.com/cancerberoSgx/slap.git
My two cents. (will PR to several projects, but I doubt there's something maintaining it ? Also, IMHO, it makes more sense to have a mono repo with the projects inside.
This is unfortunately broken in Jun 2019. It seems to break in almost the same way, here complaining about the install script of superstring@2.3.6
; any ideas?
Just tried
npm i -g git+https://github.com/cancerberoSgx/slap.git
and it did worked fine for me in mac and linux - node 12. You need to have C/C++ make gmake dev tools installed , superstring is the support for atom editor's buffer (text-buffer) written in C/C++ ... that's what slap is using. I upgraded to latest some month ago and slap worked fine... perhaps paste the error ? Thanks
Certainly.
CXX(target) Release/obj.target/superstring/src/bindings/marker-index-wrapper.o
../src/bindings/marker-index-wrapper.cc:73:92: error: too few arguments to
function call, single argument 'context' was not specified
...constructor_template->GetFunction());
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:5947:3: note: 'GetFunction'
declared here
V8_WARN_UNUSED_RESULT MaybeLocal<Function> GetFunction(
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:347:31: note: expanded
from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
^
../src/bindings/marker-index-wrapper.cc:113:15: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
js_array->Set(i, Nan::New<Integer>(marker_ids[i]));
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3367:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:122:12: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
range->Set(Nan::New(start_string), PointWrapper::from_point(pair.sec...
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:123:12: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
range->Set(Nan::New(end_string), PointWrapper::from_point(pair.second.end));
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:124:20: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
result_object->Set(Nan::New<Integer>(pair.first), range);
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:210:18: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
invalidated->Set(Nan::New(touch_string), marker_ids_set_to_js(result...
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:211:18: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
invalidated->Set(Nan::New(inside_string), marker_ids_set_to_js(resul...
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:212:18: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
invalidated->Set(Nan::New(inside_string), marker_ids_set_to_js(resul...
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:213:18: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
invalidated->Set(Nan::New(overlap_string), marker_ids_set_to_js(resu...
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:214:18: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
invalidated->Set(Nan::New(surround_string), marker_ids_set_to_js(res...
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:246:13: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
result->Set(Nan::New(start_string), PointWrapper::from_point(range.start));
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:247:13: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
result->Set(Nan::New(end_string), PointWrapper::from_point(range.end));
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:350:43: error: too few arguments to
function call, single argument 'context' was not specified
max_count = js_max_count->NumberValue();
~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:2564:3: note: 'NumberValue'
declared here
V8_WARN_UNUSED_RESULT Maybe<double> NumberValue(Local<Context> context) const;
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:347:31: note: expanded
from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
^
../src/bindings/marker-index-wrapper.cc:356:16: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
js_result->Set(Nan::New(containing_start_string), marker_ids_vector_...
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:362:20: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
js_boundary->Set(Nan::New(position_string), PointWrapper::from_poi...
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:363:20: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
js_boundary->Set(Nan::New(starting_string), marker_ids_set_to_js(b...
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:364:20: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
js_boundary->Set(Nan::New(ending_string), marker_ids_set_to_js(bou...
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:365:22: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
js_boundaries->Set(i, js_boundary);
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3367:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
../src/bindings/marker-index-wrapper.cc:367:16: warning: 'Set' is deprecated:
Use maybe version [-Wdeprecated-declarations]
js_result->Set(Nan::New(boundaries_string), js_boundaries);
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
17 warnings and 2 errors generated.
make: *** [Release/obj.target/superstring/src/bindings/marker-index-wrapper.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack at ChildProcess.emit (events.js:200:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Darwin 18.6.0
gyp ERR! command "/usr/local/lib/node_modules/node/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/local/lib/node_modules/slap/node_modules/superstring
gyp ERR! node -v v12.4.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! superstring@2.3.6 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the superstring@2.3.6 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
@oliver-daniel same here
@iAyaz @oliver-daniel - my fork - cancerberosgx/slap currently doesn't work with node 12 - only 11 and older (i'm working on it). I updated install instructions in my original comment https://github.com/slap-editor/slap/issues/411#issuecomment-487265826
update: this is now the dependency not supporting node 12 - https://github.com/atom/superstring/issues/75 waiting for it. I will probably grab all dependencies in a mono-repo to have more control since This seems to be common in this kind of projects, anybody interested on joining efforts / suggestions ?
update: this is now the dependency not supporting node 12 - atom/superstring#75 waiting for it. I will probably grab all dependencies in a mono-repo to have more control since This seems to be common in this kind of projects, anybody interested on joining efforts / suggestions ?
Dear @cancerberoSgx Dear @oliver-danielm, @alicesypark
Based on your work i followed up on all the issues pertaining to upstream build failures in a NodeJS 12 context, also stumpeling onto other issues in the dependency chain (like unreferenced required binaries & build tools @ atom/text-buffer
), which thwarted successful builds in a perfect dependency-hell clusterf*ck.
It required forking 5 repos (text-buffer
, base-widget
, slap
, superstring
, editor-widget
) - but it worked in the end. I started the work off of @cancerberoSgx 's fork, and then went from there. I can create PRs if desired.
To install slap
globally, under NodeJS 12, simply do (via my GitHub repo):
npm install --global git+https://github.com/sidneys/slap.git#master
Cheers, Looking forward to your Feedback. S
See this issue, I have answered it, #414
This project seemed like it was the solution to all my terminal editing woes, but installing it is a slap in the face. I can't believe the install process is so messy :(
@sidneys your solution sadly isn't compatible with Node LTS v14.
So sad.
@darkguy2008 Wow, such entitlement. Here's a thought: why don't you use your smarts for the good of the community (and yourself) and contribute a better install process?
@darkguy2008 Wow, such entitlement. Here's a thought: why don't you use your smarts for the good of the community (and yourself) and contribute a better install process?
I always do when I find the solution, unfortunately for this project, I don't have the time nor the will to go through the messy process of fixing npm dependencies, but I think it's evident how hard it is considering there's about 3+ issues opened about the install process:
Plus, the shell script wants to install Node v6 which is pretty old already. I fail to see how there's users still using this, and nobody (not even the owner) seems to have showed any interest in fixing it properly. The last commit was in 2016 so... I'd say it's pretty much abandoned.
If my comment is offensive to you I suggest you just keep scrolling or ignore it, I'm entitled to my opinion as much as you are, and I lost about 30 minutes or so just trying to get this going without success.
The project (and the author thereof) is very much dead, sadly. cf. this comment
The project (and the author thereof) is very much dead, sadly. cf. this comment
Oof.Size() = Int32.MaxValue;
Oof, really. That's a bummer, and now I feel bad... Alright, I'll try to see if I can find a solution to this ASAP, and maybe make a PR/fork or something.
So sad though :(
If anyone is still interesting in this editor, I have a fork that runs under node 16(haven't tried 17).
My plan is maintain the project as open source/update the codebase as i get time.
Personally I like js more than lua/vimscript/emacs, so this editor seemed like nice change of pace.
It also uses less resources than VSCode
My plan is maintain the project as open source/update the codebase as i get time.
:) Please share the fork, thanks!
My plan is maintain the project as open source/update the codebase as i get time.
:) Please share the fork, thanks!
That would be https://github.com/ajstrand/slap Though it hasn't been updated in a while.
@cancerberoSgx @Toby222 i ran into issues trying to convert the project to use es2015/es6 modules, so right now the project is kind of at a standstill.
I’ll post the branch that I’ve been working with later this evening or tomorrow.
Feel free to fill issues/pull requests if you would like to contribute.
$ npm i -g slap@latest
command fails;
/home/oytun/.npm/_logs/2019-02-08T11_14_40_409Z-debug.log last lines;