search

slapperwan / gh4a

Github client for Android
Apache License 2.0
1.7k stars 221 forks source link

[Feature request] Support discussions #1008

Open KaKi87 opened 4 years ago

KaKi87 commented 4 years ago

Hello,

I get notifications on OctoDroid for discussions but clicking on these won't do anything.

As a first step, it would be great if the app could redirect me to the browser after clicking it so I can see the content anyway.

Then, if possible, supporting these natively would be great.

Thanks

maniac103 commented 4 years ago

Are you referring to this feature?

KaKi87 commented 4 years ago

It seems so, yes. I've discovered this on the vercel repo. Thanks

KaKi87 commented 3 years ago

Any news on this ? Thanks

qwerty287 commented 3 years ago

@maniac103

Are you referring to this feature?

I'd think it's this: https://docs.github.com/en/discussions

But it looks like there is currently only a GraphQL API for this (https://docs.github.com/en/graphql/guides/using-the-graphql-api-for-discussions)

KaKi87 commented 2 years ago

Hello, would it be possible, at least, to not mark notifications as read when clicking on those since not openable ? Thanks

BloodRaven0 commented 2 years ago

+1 I'm really surprised that there is no github client that supports discussions, why is that?

jedie commented 2 years ago

+1 Would be cool to support discussions

Norbiros commented 2 years ago

Maybe you can add icon, add way to make this notification read, and to open link to discussion in your browser.

danielzgtg commented 1 year ago

I have a worse problem. I get notifications in the Gmail app and can't open the "view it on GitHub" links. With this app installed, I only get a toast saying "The link could not be opened: no browser was found on your device". The only way they will work is if I long press them and press "Open in Browser".

maniac103 commented 1 year ago

@danielzgtg This is rather off-topic here, but is it possible that you're both on a recent Android version (11 or newer) and on an old OctoDroid version (< 4.6.7)? This kind of problem should be solved since https://github.com/slapperwan/gh4a/commit/f0c7c10825e32f0bbee8fee0b88b7e34e5b82b4c

danielzgtg commented 1 year ago

@maniac103 This browser bug only occurs for discussions. I tapped "view it on GitHub" for your issue comment https://github.com/slapperwan/gh4a/issues/1008#issuecomment-1330749430 just now and it works. I am on Android 13 with OctoDroid 4.6.10 from Google Play. The specific discussion the bug occurs for is https://github.com/eslint/eslint/discussions/16557#discussioncomment-4264538.

Wjxfi commented 1 year ago

we are still waiting

zcattacz commented 1 year ago

The ability to open it in browser would be nice to have. Since the discussion have sub features like polls etc, supporting it natively maybe a non trival project on itself.

Secret-chest commented 1 year ago

There must be an API somewhere, if giscus.app exists which uses said API.

KaKi87 commented 5 months ago

Hello, any news on opening discussions in browser when clicking notifications ? Thanks

Fs00 commented 3 months ago

@KaKi87 See https://github.com/slapperwan/gh4a/issues/1336#issuecomment-2212551262

KaKi87 commented 3 months ago

So the notifications API doesn't even provide the discussion ID ?

How about the next best thing then : linking to a search page using the title : https://github.com/{owner}/{repo}/discussions?discussions_q={title} ?

zcattacz commented 3 months ago

If no one knows about this, how can they support. Maybe open a popup, show 2 item: