search

slapperwan / gh4a

Github client for Android
Apache License 2.0
1.73k stars 221 forks source link

[Dark Theme] Set background to black #1030

Open hXtreme opened 4 years ago

hXtreme commented 4 years ago

When using dark mode on an Amoled device the dark grey background makes the screen light up.

Experience of using Dark theme on Amoled devices would improve significantly not to mention the bump in battery life.

Screenshot_20200903-062629

maniac103 commented 4 years ago

I don't exactly agree there. The background isn't black anyway (it's a very dark grey), and I don't see why a medium grey divider on a dark grey background would be more distracting/disturbing than a medium grey divider on a white background (light theme) ... can you expand on this assertion?

hXtreme commented 4 years ago

Okay, I thought that the background was black and the dividers were the reason why my screen was lit up. Let me correct the issue then to ask for black background.

maniac103 commented 4 years ago

No need to ... please see #957 for my opinion on that. In short: won't happen, at least unless someone sends a PR. In general, OLED only lights up single pixels ... a single lit up pixel on a black background should be visible as just that, not as some 'lit up region'.

hXtreme commented 4 years ago

wow! that series of issue threads became increasingly angry.

Would it be okay if I create a pr that adds a Amoled theme that is basically just inherited from dark except for background colour set to black (and maybe black dividers). That way there would be no need to mess with headers and their colours.

maniac103 commented 4 years ago

Would it be okay if I create a pr that adds a Amoled theme that is basically just inherited from dark except for background colour set to black (and maybe black dividers).

Yes, as long as the 'black' theme stays separate from the 'dark' one (IOW, have 4 theme options: system defined, light, dark, black). I'm not that convinced of the black (or rather, invisible) divider idea though ... is there any strong predecent for this in other apps?

That way there would be no need to mess with headers and their colours.

That's not an option for me anyway. That discussion also happened during the Holo -> Material design conversion; I'm pretty sure header colors are a moot point by now.

yephny commented 3 years ago

Any update on this issue?

This is important also for consistency. Many apps do have a black theme option. If you like to have that on all your apps, OctoDroid will unnecessarily stand out.

Lucky-069 commented 2 years ago

This is actually much needed! I can't tolerate dark theme at all.

hXtreme commented 2 years ago

I've switched to using GitHub official app so people should feel free to implement this since I won't be.