search

slapperwan / gh4a

Github client for Android
Apache License 2.0
1.72k stars 221 forks source link

Show more descriptive OAuth restriction error, instead of "Comment creation failed" #1080

Open smichel17 opened 3 years ago

smichel17 commented 3 years ago

Tried to reply to https://github.com/streetcomplete/StreetComplete/commit/11310baac23250581b6989eb36afc8e68bcd222d#commitcomment-52700330 and got an error message, "Comment creation failed". I can grab a log if you'd like.

maniac103 commented 3 years ago

Yeah, a log would be helpful, thanks.

smichel17 commented 3 years ago

Okay, turns out this is an OAuth restriction, so the inability to comment is not Octodroid's fault. (Aside: and it's silly that there's restrictions on the ability to comment on public repos… but this also isn't Octodroid's fault)

com.gh4a.ApiRequestException: Although you appear to have the correct authorization credentials, the streetcomplete organization has enabled OAuth App access restrictions, meaning that data access to third-parties is limited. For more information on these restrictions, including how to enable this app, visit https://docs.github.com/articles/restricting-access-to-your-organization-s-data/ (403)

It would be very helpful if the app could surface this information in some way, so that someone unable to obtain a logcat would know to contact the org admins rather than file an issue here :slightly_smiling_face:

smichel17 commented 3 years ago

Maybe instead of a "Retry" action on the snackbar, it could be "Details", and open a dialog that displays the message from the GitHub api & has Retry/Dismiss actions.