search

slapperwan / gh4a

Github client for Android
Apache License 2.0
1.73k stars 221 forks source link

Improve "Large diffs aren't rendered by default" cases #1221

Open xabolcs opened 2 years ago

xabolcs commented 2 years ago

I wasn't able to view the diff of commit a57585220f9dbd9265ad517a39961f5ac9bf75f3.

Tapped to the line stats (+2, -2) and nothing happened.

Opening the commit in browser showed that its a large diff. Are there any way to show a hint in OctoDroid?

maniac103 commented 2 years ago

Not sure. This happens whenever the commit object returned by the API does not include the diff for the respective file. The only chance I see is checking whether there's a way to get a link to that specific file in the GH web UI, so we can open it in the browser.

xabolcs commented 2 years ago

For me a toast with a message "Large diff ..." would more than enough, no need to view those diffs in app.

I just didn't have any clue why doesn't work the new OctoDroid release. :upside_down_face: Of course, that "Large diffs ..." and a question "Would you like to open it in browser?" would be a nice improvement.