search

slapperwan / gh4a

Github client for Android
Apache License 2.0
1.68k stars 221 forks source link

Support for github discussions #1336

Open riedel opened 2 months ago

riedel commented 2 months ago

New discussion entries are shown in notifications but are not clickable.

At least opening the web page would be great, however, they are not much different from issue comments.

Fs00 commented 2 months ago

As much as I'd like to implement support for discussion notifications, the GitHub API doesn't yet provide the data we need. I sent a feature request some time ago but they haven't done anything about it yet. Feel free to upvote it to try and get their attention 🙏

ihatemakinganaccount commented 2 months ago

@Fs00 would it be possible to add discussions just as a feature/tab/screen on those hubs that have them, even if not directly clickable from a notification? Or am I just stupid, but I've not found a way to see discussions from OD.

I've also seen topics that were converted from issues to discussions, where in OD they show up only up to the point of being converted, at which point they appear as if locked by a bot.

Fs00 commented 1 month ago

Implementing full support for discussions in the app (like we have for issues and pull requests) is surely possible but would be a pretty big task and I personally don't have much time and motivation for doing that. A simpler addition that shouldn't take much work could be a "Discussions" shortcut in the repository "About" tab (displayed only for repos that have them) that opens the discussions page in the browser.

I've also seen topics that were converted from issues to discussions, where in OD they show up only up to the point of being converted

This is another case of the GitHub API endpoint we use not returning the data we need... 😔 The solution would be to reimplement issue/PR timeline fetching to use the newer GraphQL API, but it's a lot of work.

Cwpute commented 1 month ago

A simpler addition that shouldn't take much work could be a "Discussions" shortcut in the repository "About" tab (displayed only for repos that have them) that opens the discussions page in the browser.

That would be a perfectly valid workaround, until the API allows for full support. I'd pirsonally prefer it being opened in my browser of choice, but directly inside the app is good enough.