search

slapperwan / gh4a

Github client for Android
Apache License 2.0
1.72k stars 221 forks source link

Mark as read on notifications page for entire repo does nothing #900

Open gdevenyi opened 5 years ago

gdevenyi commented 5 years ago

Using the notification page, I can mark individual items as read but if I do it for a whole repo it shows them as read but reloading the page shows the entries are all unread again.

Doing the same thing with a single entry works as expected.

maniac103 commented 4 years ago

FWIW, I can not reproduce that.

gdevenyi commented 4 years ago

Just tested again, still reproduces.

smichel17 commented 4 years ago

I can also repro,

maniac103 commented 4 years ago

Are you using the button for each repo (to the right of the repo name) or the 'mark all read' button (in the action bar at the top)?

maniac103 commented 4 years ago

Also @smichel17 does anything relevant show up in Logcat?

smichel17 commented 4 years ago

To the right of the repo; IIRC the action bar button works. I'll grab a logcat in a moment, pending another notification..

smichel17 commented 4 years ago

@maniac103 Do I need to be running a debug build rather than from f-droid? I was just trying to find the process ID to filter on but I didn't see anything in my unfiltered logcat that looked like it was coming from octodroid… (granted, there is a lot of noise, I might have missed it)

maniac103 commented 4 years ago

Exceptions should be logged in release build as well, but HTTP requests/responses are only logged in debug builds. Everything that's logged should appear under the 'Gh4a' tag.

smichel17 commented 4 years ago

This is all I get with a grep -i gh4a in the release build. I'll try with debug some time later, unless you'd like to add additional logging first.

2019-12-18 11:37:55.541 3671-7057/? D/WindowManager: openInputChannel mInputChannel: d811c1e com.gh4a/com.gh4a.activities.home.HomeActivity (server)
2019-12-18 11:37:55.564 3671-4556/? V/WindowManager: Relayout Window{d811c1ed0 u0 com.gh4a/com.gh4a.activities.home.HomeActivity}: viewVisibility=0 req=1368x585 WM.LayoutParams{(0,0)(wrapxwrap) gr=#11 sim=#120 ty=2 fl=#1820002 fmt=-3 wanim=0x7f100002 surfaceInsets=Rect(128, 128 - 128, 128) needsMenuKey=2 naviIconColor=0}
2019-12-18 11:37:55.622 3671-3882/? D/WindowManager: finishDrawingWindow: Window{d811c1ed0 u0 com.gh4a/com.gh4a.activities.home.HomeActivity} mDrawState=DRAW_PENDING
2019-12-18 11:37:55.649 3671-1161/? D/WindowManager: finishDrawingWindow: Window{d811c1ed0 u0 com.gh4a/com.gh4a.activities.home.HomeActivity} mDrawState=HAS_DRAWN
2019-12-18 11:37:59.502 3671-3694/? D/WindowManager: disposeInputChannel mInputChannel: d811c1e com.gh4a/com.gh4a.activities.home.HomeActivity (server)
2019-12-18 11:37:59.561 3671-3707/? I/WindowManager_SurfaceController: Destroying surface Surface(name=com.gh4a/com.gh4a.activities.home.HomeActivity) called by com.android.server.wm.WindowStateAnimator.destroySurface:2907 com.android.server.wm.WindowStateAnimator.destroySurfaceLocked:1120 com.android.server.wm.WindowState.destroyOrSaveSurface:2692 com.android.server.wm.AppWindowToken.destroySurfaces:424 com.android.server.wm.AppWindowToken.destroySurfaces:388 com.android.server.wm.WindowStateAnimator.finishExit:686 com.android.server.wm.WindowStateAnimator.stepAnimationLocked:570 com.android.server.wm.WindowAnimator.updateWindowsLocked:439