search

slara / generator-reveal

Yeoman generator for Reveal.js
MIT License
429 stars 52 forks source link

coffelint task fails when generated lines are too long. #45

Closed slara closed 10 years ago

slara commented 10 years ago

For example, when the user selects the default github user and repo name, the test fail with:

Running "coffeelint:all" (coffeelint) task

Gruntfile.coffee ✖ line 101 Line exceeds maximum allowed length Length is 84, max is 80 ✖ 1 error

janraasch commented 10 years ago

We could add

max_line_length:
        level: 'ignore'

to the coffeelint task configuration, i.e.

coffeelint:
        options:
            indentation:
                value:
            max_line_length:
                level: 'ignore'

        all: ['Gruntfile.coffee']

in app/templates/_Gruntfile.coffee.

I think that is okay for the use case.

slara commented 10 years ago

Yes, this is a good solution as, for this use case, we don't need to be that strict.