Closed tristola closed 9 years ago
Neat idea. We just have to make sure not to confuse people and ourselves with too many options. Esspecially the existing useSass
and this one have to be clearly distinct.
useSass
and only if the answer was no, ask the user which of the existing precompiled .css
themes he/she wants to use.:+1:
As @janraasch says, an options list would be nice. Following #42, we could add some kind of theme preview.
Changed to 1) only select theme when useSass is false 2) give list of revealjs themes to select from.
Thanks for the quick update, @tristola. One last thing: app/revealThemes.js
does not need to be JavaScript. You could simply use a app/theme_choices.json
file with content like
[
{"name": "beige", "value": "beige" },
{"name": "blood", "value": "blood" },
{"etc": "etc....."}
]
You can then use that in RevealGenerator#constructor
as
themes = JSON.parse @readFileAsString path.join __dirname, './theme_choices.json'
Also, could you write a testcase for a choice different from the default default
? Just so we have that covered as well.
Added test and moved themes list to theme_choices.json
Thanks, @tristola. @slara, could you prepare a release with this?
v0.3.10 is out and is really an awesome release! Thanks everyone!
:+1:
Coverage increased (+0.01%) when pulling 0196f724cb745bd2cca4bd9c2eac712cb89ae83a on tristola:master into 0b63e2fa5a2102ba4df4fd5c5b2d871e76651039 on slara:master.