slara / generator-reveal

Yeoman generator for Reveal.js
MIT License
429 stars 52 forks source link

use https i.s.o. git for github repository #79

Closed riezebosch closed 8 years ago

riezebosch commented 8 years ago

Is there a reason you generate the github url using the git-protocol? As far as I know there is no authentication possible so it makes it useless to push via this protocol.

janraasch commented 8 years ago

Hi @riezebosch, thank you for your contribution.

Three things:

First, tests are failing. 😭 😉

Second, I have not heard any complaints about the git@github.com: url and it was implemented this way, since it was released with 9d2bdcc2517e51142f2673413b20a0f636c926af. Also, I am quiet confident that other people do use this, since there were issues related to this feature (see https://github.com/slara/generator-reveal/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aclosed+deploy). So I am not so sure about your statement:

[...] so it makes it useless to push via this protocol

Could you make sure that it is not a configuration issue on your end?

Third, what is your exact issue? Can you post an error message and ways to reproduce the problem you are facing?

Thank you.

riezebosch commented 8 years ago

The git protocol does not support authentication: https://git-scm.com/book/ch4-1.html#The-Git-Protocol. Probably everyone configured git to use https instead of git: http://stackoverflow.com/a/10729634/129269 My main problem is I cannot push using the git protocol inside the company since the used port is blocked by the firewall.

janraasch commented 8 years ago

OK. I understand.

Two things (still :))

  1. Are there any downsides to https: (over git:) that we should be aware of?
  2. Could you adjust the failing specs?
coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 96.842% when pulling 7fe819fa9c088d6752d1ecc1bdf323c002f7e17e on riezebosch:slara into 72a189f6e8ef31e73928363a93b2121066ad1cf3 on slara:master.

slara commented 8 years ago

Hi @riezebosch,

Authentication with git@github.com should work if you have your SSH keys correctly configured. https: requires that you type your credentials every time and it does not work well with two factor authentication.

Can you verify if your keys are OK, please? Thanks

EDIT: grunt-build-control configures your repository to use ssh as protocol.

riezebosch commented 8 years ago

My bad! I assumed that the git protocol was used because of the git@ prefix. Turns out that this is the "scp-like syntax" which indeed triggers the SSH protocol.

slara commented 8 years ago

@riezebosch Indeed! Authentication should work OK if you have SSH configured. Please verify that you can git push your commits to master and deploy to gh-pages with grunt deploy.

janraasch commented 8 years ago

Thank you, @slara. 👍