'make install' should respect $DESTDIR

slash-lang / slash

A new language for the web

http://slash-lang.org

MIT License

386 stars 22 forks source link

'make install' should respect $DESTDIR #41

Closed anatol closed 2 months ago

anatol commented 10 years ago

Signed-off-by: Anatol Pomozov anatol.pomozov@gmail.com

richo commented 10 years ago

If you set a relative PREFIX, this will cause it to become relative to / if DESTDIR is unset, which is probably not the right behaviour.

Apart from that it looks fine to me.

anatol commented 10 years ago

If you set a relative PREFIX

It sounds like you want to use DESTDIR here. PREFIX is usually one of the /usr /usr/opt /usr/local ... i.e. relative to the root of the system. At least it is the way its done in the most Makefiles I have seen.

If you still want to keep that behavior then you need to remove / between DESTDIR and INSTALL_PREFIX

anatol commented 10 years ago

FYI: I just added slashlang package to Linux Arch https://aur.archlinux.org/packages/slashlang-git/

The pull request above is required to build the package correctly.

anatol commented 10 years ago

Any chance to see this issue fixed?