Closed un1versal closed 9 years ago
@fyfe WORK on this front https://github.com/slash2009/XWMM/pull/136
I appreciate the work @uNiversaI.
Ok here's what I've done so far:
Now for the testing:
This will install the correct version for which ever version of Kodi you are running and provide automatic updates.
It'll be next week before I've got access to a machine running Kodi so if people can test this on Helix and Isengard it would be appreciated.
At the moment my script that automatically updates the repository when a release is tagged doesn't work with this new layout, I'm working on an updated one hopefully I'll get it done this weekend.
why do you need a repo for each? the repo addon.xml I done does all, no? Just like the kodi default repo works. Having separate repository is more cumbersome having to ask people to install specific stuff when one does all
See https://github.com/slash2009/XWMM/issues/136 which should Ill update with your changes to reflect your work on the server side
<dir minversion="14.0.0">
<info compressed="true">http://kodi.neptune-one.net/addons/helix/addons.xml</info>
<checksum>http://kodi.neptune-one.net/addons/helix/addons.xml.md5</checksum>
<datadir zip="true">http://kodi.neptune-one.net/helix/addons</datadir>
<hashes>true</hashes>
</dir>
<!-- Isengard -->
<dir minversion="14.9.0">
<info compressed="true">http://kodi.neptune-one.net/addons/isengard/addons.xml</info>
<checksum>http://kodi.neptune-one.net/addons/isengard/addons.xml.md5</checksum>
<datadir zip="true">http://kodi.neptune-one.net/addons/isengard</datadir>
<hashes>true</hashes>
also
<import addon="xbmc.addon" version="12.0.0"/>
is wrong, I think, that's for frodo and will fail to install via zip, At least it did on my tests. What worked was
<import addon="xbmc.addon" version="14.0.0"/>
just like I done in first place. Just my two cents.
What we need is a way to make the wimm addon.xml contain correct structure for each release. Like you say and we cooking with fire.
Ill update https://github.com/slash2009/XWMM/issues/136 with the changes.
What I may suggest for future proofing that require minimal maintenance server side is instead of using helix or isengard to use something more generic like "current" and "development", so all the changes for future work in the repo addon.xml is the <dir minversion="14.9.0">
change***
no?
Oops that was me typing without engaging my brain. You're right there is only one version of the repository add-on it's just included in both repositories. I've adjusted the instructions.
read my post again. updated
Generally It would be better to keep repo like I suggest in #136 also We should keep this simple and stupid tbh.
also http://kodi.neptune-one.net/addons/isengard/webinterface.WIMM/addon.xml thers a typo in there in the disclaimer field.
Best look at #132 as well mate, thx for your work server side, appreciate it, with something generic there as commnets above should make future work easier on us.
all in all these things need fixing really. Sorry for the long list of comments but these things need to be right for everyone benefit and sanity.
note I need to redo #136 PR because I realised I can create an empty branch with
git checkout --orphan repository.wimm.web
@fyfe
Right see https://github.com/slash2009/XWMM/tree/repository.wimm.web and https://github.com/slash2009/XWMM/releases/tag/v.1.0.0
That should address part of my comments and keeps it all in one development roof and releases all done in one place for all.
Todo list for @fyfe
See this comment
There's going to be more breaking changes to web interface add-ons in Kodi before Isengard is released. Until it hits beta (maybe alpha) release state I'm not going to play catch up.
next month beta, the commit already been done.
Having repository being provided in addon, is practical but will become a messy hack, and more confusing to maintain both repo and addon imo.
This is based on https://github.com/xbmc/xbmc/blob/master/addons/repository.xbmc.org/addon.xml
Only thing that needs handling is the _isengard_ directory portions and provide releases compatible with isengard new
<extension point="xbmc.webinterface"/>
Im unsure how @fyfe wants to handle two repos or however needed to make sure it works when releases for addon are made. Somewhat beyond my ability.
This is how it would look.
Test zip for repo https://github.com/uNiversaI/WIMM/releases/download/1.0.0/repository.wimm.web-1.0.0.zip
This should work for existing Helix addon, not yet for isengard..
Please @fyfe handle the isengard directories on repo server and whatever else required there as Im unable to access this.