search

slash2009 / XWMM

XBMC Web Media Manager
Other
56 stars 20 forks source link

Ignore articles (e.g. "the") when sorting movies #21

Closed nwtn closed 11 years ago

nwtn commented 11 years ago

This should probably end up behind a preference/toggle/option, but I think it makes sense as a default. At least, it does for me :)

Feel free to pull it in or not as you see fit.

un1versal commented 11 years ago

Considering that in XBMC it is behind a option, it would be ideal that this would also be behind option no? Idk if this is default behaviour in XBMC so if whoever doesn't have that checked in XBMC may be slightly confused then by new sorting logic... idk just a comment, as I dont understand code part anyway

For time being Ill wait to see if anything becomes of this in the form of a more matured option it can always be merged later on anyway.

Thanks you.

nwtn commented 11 years ago

I tried to figure out a way to read the user's XMBC settings to determine this, but it looks like it's not currently possible (see http://forum.xbmc.org/showthread.php?tid=173380&pid=1505613).

So, we'd need to make it an option within XWMM for now. I'll work on it a bit.

un1versal commented 11 years ago

Yes according to that XBMC forum post @Montellese its probably possible in current XBMC but not say 12.2, but either way its beyond me. Im just the janitor around here. It would seem if it possible the API and json-RPC need exploring

Thank you for looking into it.

nwtn commented 11 years ago

For now, until the XBMC stuff is sorted out, this will at least allow users to set a preference here to match their XBMC pref. It's just a cookie, so it's browser-dependent, but it's better than nothing.

nwtn commented 11 years ago

In the clear light of morning, I realize declaring storeMovie could be a lot cleaner. I'll update the PR either later tonight or tomorrow.

un1versal commented 11 years ago

I would suggest you squash and then push the PR and maybe even sync your Fork before that.

Once you have done that can you also please push the same PR to Frodo Branch?

Thank you

nwtn commented 11 years ago

Updated my fork and did a squash, but doesn't seem to have affected this PR. Going to close and try resubmitting.

un1versal commented 11 years ago

Ya git takes a little getting used to :) np.