search

slash2009 / XWMM

XBMC Web Media Manager
Other
56 stars 20 forks source link

Movie set changes not reflected in UI after updating movie details #49

Closed criticalfiction closed 10 years ago

criticalfiction commented 10 years ago

Running 3.0.1 on Frodo.

Steps to reproduce:

  1. From the movie list, select a movie without a set
  2. From "Other Details" select a set from the dropdown
  3. Click "Save"

Expected outcome: For the set to be saved. The set icon should appear next to the movie in the list, and on switching away and back to the movie, for the set to appear selected in the dropdown.

Actual outcome: The set is not saved. The icon does not appear next to the movie in the list, and on switching away and back to the movie, the dropdown has no set selected.

EDIT: Updated problem description.

un1versal commented 10 years ago

Clear you cache and reload XWMM, it works fine here with Firefox or Chrome.

criticalfiction commented 10 years ago

My apologies. The set is actually saved, but the UI doesn't get updated (i.e. as described above, the icon doesn't appear next to the movie, and on selecting a different movie and then the first one again, the set pre-selected in the dropdown remains as it was prior to changing it). I will update the summary.

I had already tried clearing my cache. I double-checked again just in case, but I'm still having this issue.

I stepped through the JS and saw that at line 64 of movies/include.js, currentMovie is always undefined. As a result, line 65 doesn't execute either. This might be where the problem lies.

un1versal commented 10 years ago

It may be, for that Im marking this therad and not closing it, you can either fix it on master and submit a PR or wait till your old and dead for someone to fix it for you.

XWMM desperately needs developers ;)

Good luck anyway, I dont know any of the deving myself, im just a glorified janitor here.

criticalfiction commented 10 years ago

I'll see if I can take a closer look this weekend, though I can't promise much - I'm not familiar with ext.js and it looks like XWMM uses a version which is no longer supported (it would be good to get a non-minified version for debugging).

un1versal commented 10 years ago

closed as you fixed it ;) thx for fix.

criticalfiction commented 10 years ago

No problem. Thank you for maintaining XWMM. :)

un1versal commented 10 years ago

Thx

Im only doing the git janitor job, you guys are the ones maintaining :dancer:

Ive cherry picked it into frodo and gotham only need to update releases its been added to changelog as well though I need to updatee master changelog too :dart: