search

slash2009 / XWMM

XBMC Web Media Manager
Other
56 stars 20 forks source link

Update xbmc.js #51

Closed criticalfiction closed 10 years ago

criticalfiction commented 10 years ago

This should fix issue #46 - tested locally against Frodo.

Not tested, but should work on Gotham too.

un1versal commented 10 years ago

Thx, should have waited a whle before starting to do changelogs and cherry picking haha :dancer:

Gimme a while probably for tomorrow now.

criticalfiction commented 10 years ago

No worries - don't think I'll have any more commits today. Might take a look at how genres work to see if I can do anything about those.

un1versal commented 10 years ago

Ya thank you, We need all the hands we can get. :dango: will do it asap.

un1versal commented 10 years ago

there was just a slight problem since both your pr's contained the same fix for movie sets, argh. I hate git. Its now up on master frodo and gotham...

Thank you again.

I trying to get fyfe and slash to agreen on that new direction for XWMM, as is we waiting on fyfe to submit the PR fr new master rewrite. (the one with new js suff).

criticalfiction commented 10 years ago

Sorry about that - not entirely sure how it happened. I'll check in on the project once agreed and see if I can help. :)

un1versal commented 10 years ago

ya, its all up in the air atm,one day we have to agree to all meet in IRC or something though that is going to be a feat in itself I imaged ;-)

Thank you anyway, I have now updated the releases with the new fixes.

Thx.

un1versal commented 10 years ago

@criticalfiction this stuff Actually in Gotham doesnt work

criticalfiction commented 10 years ago

I'll check it out when I've got a few minutes. If it's not working it suggests something more fundamental is broken, as all I did was correct the set on the object variable...