search

slash2009 / XWMM

XBMC Web Media Manager
Other
56 stars 20 forks source link

Delete the old movies folder and rename movies2 to movies #55

Closed ghost closed 10 years ago

ghost commented 10 years ago

I forgot to do some tidying up before #44 was merged. This sorts it all out.

un1versal commented 10 years ago

@fyfe Here is a few things I noticed off the bat with this.

1 The columns Set and watched is reverted back to S and W 2 Columns are not resizeable anymore < that no so much of problem as long as 1) is correct and showing by default. 3 Movie poster is ok but the other art is now directly below it, before it was to left somewhere 4 Movies by genre doesnt work 5 Recent movies doesnt work 6 Movie set management is not even an option. Cant add sets or manage set wise. 7 You can remove movies but you cant rescan or read them. 8 Also when any column/file is selected the selected text is unreadable.

Ya, but I like the way it uses the whole screen portion...

ghost commented 10 years ago

@uNiversaI looking back at this code it was never close to being complete. Part of the reason I started looking at doing a re-write was because I was getting so frustrated trying to reinvent the wheel every time I wanted to do something in ExtJS 3.

These two reverts undo the changes made my this PR and #44.

un1versal commented 10 years ago

Thats why I asked what you wanted to do with original PR.

So basically we reverting #44 so merging this PR does this stuff?

Rewrite is a much longer term project, meanwhile XWMM need to be fixed and made ready for Gotham, but yes, its not easy juggling the two.

un1versal commented 10 years ago

@fyfe I reverted the merge of #44 for now :-( Much easier/cleaner than Merging another PR undoing the previous.

If thats the intention feel free to close this PR and then decide what you want to do with this and repopen when its ready to go somewhere.

un1versal commented 10 years ago

@fyfe

This can be closed as I already reverted master without destroying your cleanup repo. idk what you want to do with any of it, but this is not needed atm.

When your clean-up branch is ready let me know.