[WIP] Clean up jshint warnings

slash2009 / XWMM

XBMC Web Media Manager

Other

56 stars 20 forks source link

[WIP] Clean up jshint warnings #73

Closed ghost closed 10 years ago

ghost commented 10 years ago

I've started running some of the javascript through jshint to pick up any errors/bad habits. At the moment I'm just concentrating on:

Missing ;
Unnecessary ;
Variables being used before they're declared
Calling functions before they're defined
Consistently using single quotes for strings

This is still a work in progress.

un1versal commented 10 years ago

Ill trust your coding skills on this, but and you know what Im gonna say...

Version bumps and chngleog entries pls :D hehe.

also when the time comes, rebase and squash these to make it easier, then I will merge accordingly when you give the word.

I would add you as a colaborator so you get wrtite privileges and can merge your own stuff, but this isnt my repo :D may as well not be, since my job here is rather superfluous.

ghost commented 10 years ago

The first stage is ready for merging.

This cleanup found 3 (0f8077a, 5832562, 9969240) little bugs that could cause some unpredictable results.

un1versal commented 10 years ago

Excellent

Add a large version bump as well something for e.g 4.x.x, rebase and squash (group the changes?) make this around 6 commits), I can merge this as soon as all that is ready.

ghost commented 10 years ago

Squashed, and bumped, ready to merge :smile:

un1versal commented 10 years ago

Fantastic... at this rate, well have to discussing resubmitting to xbmc repo... need some testing frst.

thx again.