slash2009 / XWMM

XBMC Web Media Manager
Other
56 stars 20 forks source link

Adding WIMM to the Kodi add-on repository #97

Closed ghost closed 9 years ago

ghost commented 10 years ago

What's stop use getting XWMM into the XBMC add-on repository...

I can't offer much for the fanart, art isn't my area of expertise :smile:

As far as a stable release goes I don't think we are far off.

un1versal commented 10 years ago

Yes thank you for check-list, as far as artwork goes I shall have something soon.

I asked in forums for screenshots of xwmm and some fanart to get some alternatives, but I dont think we can wait for that. So Ill have a look at that by the weekend should be full requirements filled.

If you think of any artwork that needs redoing please let me know.

un1versal commented 10 years ago

Here is something to start for the fanart

fanart

ghost commented 10 years ago

Looking good

un1versal commented 10 years ago

and cause fanart was feeling too lonely

icon

Also here something I noticed when installing from zip https://github.com/xbmc/xbmc/pull/4998 notspiff fixed it just awaiting merge.

on the remainder here stability I had to repopen movie set issue though its not exactly same issue and opened another report based on 4.1.6 which I kept as intrenal release so as to give it some test myself. so #88 and #99

un1versal commented 10 years ago

With f259c13f20de725d7b689c47a4ca48043622f3f6 we checkmark the fanart.jpg

I was tweaking the art in meanwhile so its all updated now with f259c13f20de725d7b689c47a4ca48043622f3f6

un1versal commented 10 years ago

We would be better served by our own repository for 3 reasons.

1) There are two api XWMM must be compatible with, The stable api and the development api, so that means tow different addon.xml

2) XWMM is unlikely to reach that mature state to be in XBMC repo at this stage given the heavy work it is undergoing.

3) Users just install the repo and be done manually installing something when there is a release be it fast paced or whenever, is hardly ideal.

Problem here is I look at other github xbmc addon repos and my mind goes blank it looks like it can handle different addon.xml and great deal more, but I have no idea about python or what they are using or how.

maybe 2) is less of an issue xbmc repo is finally an option, but then idk whats going on in background, you could just pull the rabbit out of the hat anytime which wouldn't surprise me either ;) Only problem with

un1versal commented 9 years ago

There's more issues now, the xbmc to kodi change is probably broken the addon on Helix beta releases.

Because now many strings expect to see kodi and not xbmc... no idea.

ghost commented 9 years ago

I've setup a repository on my server (kodi.neptune-one.net) that will generate releases every time a vX.Y.Z tag is created. It checks for new tags every 6 hours (00:10/06:10/12:10/18:10) so as not to hit the GitHub servers to often, Kodi only checks for updates every 24 hours so this shouldn't cause much of a delay.

Ok I've just committed f2e7e55451761f1742ed112a64e37d999efa246b which adds an the repository and created the v4.1.10-alpha3 tag. Once this version has been installed by the user they will receive automatic updates.

ghost commented 9 years ago

Also I forgot to mention this before the version number of the zip file, the folder name in the zip file and the version in addon.xml all have to match otherwise Kodi doesn't like the zip file. For example

zip folder version result
webinterface.WIMM-4.1.10.zip webinterface.WIMM-4.1.10 4.1.10 works
webinterface.WIMM-4.1.10-alpha3.zip webinterface.WIMM-4.1.10-alpha3 4.1.10 doesn't work
webinterface.WIMM.zip webinterface.WIMM 4.1.10 doesn't work

@slash2009 now that the project has been renamed we need to rename the repository to webinterface.WIMM to make life easier in the future as this is the naming scheme required to get included in the official repository.

ghost commented 9 years ago

@uNiversaI I've reverted the change to the JSON API version. There's no need for different releases for Gotham and Helix at the moment, I've tested both with v4.1.10 and they work fine.

The JSON API version number only needs bumped when we start to use features that aren't available in Gotham. The only API change in Helix that we need at the moment is the change to the scan/clean library calls, but I plan on checking the API version in code and changing the parameters based on what version is running so we can support both versions at the same time.

un1versal commented 9 years ago

Absolutely no need, crelease has api gotham, master api Helix, simple for everyone. :+1: Master is for development always, crelease for current release.

Ultimately if you are 100% sure that the gotham api version works in Helix than pointless discussing this, I had reports it didnt work Ive no idea, Ill trust your developer savvy :smile:

Also I dont care about Gotham, its outdated, XBMC itself will get no more fixes I never use stable and never will.

So. now you install the addon and because you added repo will self update? :smile: :smile: Whats happens when I push an update? As long we can push updates consistently and not have this break when someone is mia even better.

ghost commented 9 years ago

Within six hours of you tagging a release on here it'll be in the repository. So even when I go MIA it'll still work :)

un1versal commented 9 years ago

Fantastic, now we cooking with fire.

So... the only snip is the tag version has to match the addon.xml version...

Else how you going to distinguish from beta/alpha and normal? Or does it not matter?

ghost commented 9 years ago

You can still use -alphaX or -betaY you just need to update add-on.xml to match.

un1versal commented 9 years ago

Thats what I thought. Thanks. Looking forward now to future releases and see your handywork in action as usual.

Now with the repo functionality it should be easier all around and given the state of the addon it wouldnt be anywhere ready for main kodi repo, unfortunately.

Now we need @slash2009 to rename the github project to WIMM and also make the description comply with kodi trademark policy exactly like https://github.com/uNiversaI/WIMM did.

ghost commented 9 years ago

@slash2009, @uNiversaI I mentioned in #104 we need to rename the GitHub project to webinterface.WIMM, it's a requirement for inclusion in the official repository.

ghost commented 9 years ago

@uNiversaI as far as which versions of Kodi we support I want to maintain support for Gotham at least until Helix has a stable release (and probably until OpenELEC releases a Helix version). Purely because the Kodi boxes I setup for friends and family runs stable versions only (makes my life easier :-)).