search

slashdotdash / conduit

RealWorld example backend implementing the CQRS/ES pattern in Elixir and Phoenix
MIT License
355 stars 67 forks source link

Use appropriate key for configuring cost #22

Closed tt closed 5 years ago

tt commented 5 years ago

The key changed when BCrypt got extracted to a separate dependency in https://github.com/riverrun/comeonin/commit/bd39137c0b4613e3b14fc654c577cc637313549f

Using the appropriate key improves the performance of test runs significantly.

Before

% mix test --seed 0
...
Finished in 28.8 seconds
65 tests, 0 failures

Randomized with seed 0

After

% mix test --seed 0
...
Finished in 19.0 seconds
65 tests, 0 failures

Randomized with seed 0
tt commented 5 years ago

@slashdotdash, this is probably good to merge too although it's not as important as it only improves the test run performance.

(I promise this is the last one.)

slashdotdash commented 5 years ago

Thanks for the pull requests @tt.