search

slashdotdash / conduit

RealWorld example backend implementing the CQRS/ES pattern in Elixir and Phoenix
MIT License
347 stars 67 forks source link

Remove `presence` from UpdateUser Command #4

Closed hl closed 5 years ago

hl commented 7 years ago

Hey Ben, first off, great work!

I think these two lines can be removed in the command UpdateUser so they won't be mandatory when updating an existing user

https://github.com/slashdotdash/conduit/blob/master/lib/conduit/accounts/commands/update_user.ex#L21

https://github.com/slashdotdash/conduit/blob/master/lib/conduit/accounts/commands/update_user.ex#L27

slashdotdash commented 7 years ago

Yes, those fields should be made optional. Thanks for the feedback.