Closed Gouvernathor closed 6 months ago
Sorry to nag but still the Westminster diagram doesn't work in the beta version
Yep, there are other issues in python (due to py2->3 compatibility) that I'm working on addressing in another branch.
Oh okay, that makes sense
On Sun, 5 May 2024, 21:13 Gouvernathor, @.***> wrote:
Yep, there are other issues in python (due to py2->3 compatibility) that I'm working on addressing in another branch.
— Reply to this email directly, view it on GitHub https://github.com/slashme/parliamentdiagram/pull/147#issuecomment-2094934413, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIIWQNB4RGNB5TNAXYPP5OTZA2HGRAVCNFSM6AAAAABHDPI4O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHEZTINBRGM . You are receiving this because you commented.Message ID: @.***>
It's been two weeks, merging.
Hello I'm guessing it's meant to be this way but just in case, the diagrams don't save when uploaded by their links on websites as images for long
Hello I'm guessing it's meant to be this way but just in case, the diagrams don't save when uploaded by their links on websites as images for long
And the crossbenches don't work
@ljw1301
it's meant to be this way
Yes it is, there's a cache expiration and you need to download your files, we'll eventually get in trouble if we start hoarding too many archives.
And the crossbenches don't work
I'll look into that, but you can open a new issue describing the problem and how to reproduce it, as it's not really the topic of this issue.
Okay, thanks for letting me know
On Mon, 27 May 2024, 02:52 Gouvernathor, @.***> wrote:
@ljw1301 https://github.com/ljw1301
it's meant to be this way
Yes it is, there's a cache expiration and you need to download your files, we'll eventually get in trouble if we start hoarding too many archives.
And the crossbenches don't work
I'll look into that, but you can open a new issue describing the problem and how to reproduce it, as it's not really the topic of this issue.
— Reply to this email directly, view it on GitHub https://github.com/slashme/parliamentdiagram/pull/147#issuecomment-2132508503, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIIWQNHKVPJE4HBTPCU7ZB3ZEKGUJAVCNFSM6AAAAABHDPI4O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSGUYDQNJQGM . You are receiving this because you were mentioned.Message ID: @.***>
The westminster issue is #163, it's fixed in the Flask branch (it's not yet fixed on the Beta because that points to flask-oauth).
As I'm writing this, this version is deployed on the beta environment for testing purposes. Fixes #121 and #146. This aligns the layout of the US and Westminster pages with the main "arch" page. To do this, the html pages are transitioned to PHP pages, and the header with the passport photo is replaced with the heade of the arch page. Redirects are placed where pages are removed, for compatibility, though this could preferably be done at the server level. That can be done in a future update. This replaces the sample images with more up-to-date versions. Also, adds myself to the footer 🙃
No change is brought to the newarch backend. The resulting diagrams are exactly the same as before. Two more updates, after this one, are about the python backend, the last one being the Revamp update. They are the Gouv-clean-newarch and Gouv-clean-revamp branches. These three branches increment off each other.
I will merge this in two weeks (may 15th) if no feedback is provided.