Newarch code cleaning - Githubissues

slashme / parliamentdiagram

Parliament diagram creator

GNU General Public License v2.0

104 stars 29 forks source link

Newarch code cleaning #94

Closed Rade-Mathis closed 3 years ago

Rade-Mathis commented 3 years ago

This is a rewriting of newarch.py file. This pull-request is only about reorganizing/cleaning the code :

The outputted SVG is totally the same
The algorithm used to generate it is also the same
The only behavior modification is actually an added log (at the line 45)

The objective is to make the code more understandable, and hence, more easily modifiable.

Aesthetic choices have been made here:

Use of camel_case identifiers (standard in python as far as I know)
80 column rule (some people consider it standard, but not everybody agrees on that)
numpy style function documentation strings (because why not)

Tell me if any coding style choice is improper and should be replaced with another, I'll apply needed changes.

NB: I sent you a mail on your Gmail address, some comments in this commit are related to it.

Rade-Mathis commented 3 years ago

At the light of your email, I have to change a few things. It'll be back soon hopefully.

slashme commented 3 years ago

I've started looking at the work you've done so far, and I really like it!

Would you have a chance for a voice call? I've finished work and I have time. Pretty much any VOIP system is fine: zoom, Google Chat, Telegram, WhatsApp, etc. etc.

David Richfield +49 176 7266 3368

On Mon, 26 Apr 2021 at 18:43, RadeMathis @.***> wrote:

At the light of your email, I have to change a few things. It'll be back soon hopefully.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/slashme/parliamentdiagram/pull/94#issuecomment-826988009, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADFGK2IVCGFDUUIDWHWMFDTKWJ3DANCNFSM43RSNLPA .

Rade-Mathis commented 3 years ago

I don't really like phones calls. I will if needed, But I'd prefer text chat if possible. I can make myself available tomorrow evening, from 6:40 PM up to whatever.

slashme commented 3 years ago

Text chat is fine! Let's try 19:00. What platform do you prefer? IRC, slack, Google ... ?

RadeMathis @.***> schrieb am Mi., 28. Apr. 2021, 00:05:

I don't really like phones calls. I will if needed, But I'd prefer text chat if possible. I can make myself available tomorrow evening, from 6:40 PM up to whatever.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/slashme/parliamentdiagram/pull/94#issuecomment-827967082, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADFGK46CGKL4PMFPU72R3TTK4YL7ANCNFSM43RSNLPA .

Rade-Mathis commented 3 years ago

I'll be able to vocal. You can join me here if it suits you: https://discord.gg/ZTtq3J8P

slashme commented 3 years ago

Great, will be online in about 10 minutes.

RadeMathis @.***> schrieb am Mi., 28. Apr. 2021, 18:47:

I'll be able to vocal. You can join me here if it suits you: https://discord.gg/ZTtq3J8P

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/slashme/parliamentdiagram/pull/94#issuecomment-828609441, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADFGK7KT6GZ6EOBNOEYGJTTLA3YXANCNFSM43RSNLPA .