Apply black formating and introduce pre-commit

slashmili / django-jalali

Jalali DateField support for Django model

http://pypi.python.org/pypi/django_jalali

BSD 3-Clause "New" or "Revised" License

258 stars 52 forks source link

Apply black formating and introduce pre-commit #177

Closed hramezani closed 2 years ago

hramezani commented 2 years ago

Apply black formatting to the code
Add pre-commit configuration

@slashmili Could you please add the repo to pre-commit ci? then the pre-commit will be included in our CI

slashmili commented 2 years ago

Do you think it's safe? Asking since never heard of it before and their website is so basic 😁

I'm sure they have a good intention but wondering what happen if overtime they are not into the project and leave it with unaddressed security issues.

Screenshot 2022-06-16 at 11 07 56

hramezani commented 2 years ago

I haven't checked their security TBH, but some projects like pytest , most of libs in jazzband and ... are using it. Also, it is on GitHub marketplace BTW, it's up to you. If you don't have a good feeling we can replace it with tox -r -e py38-lint in github action.

slashmili commented 2 years ago

@hramezani alright 👍🏼 it's connected to this repo

hramezani commented 2 years ago

Thanks @slashmili :+1: I just closed and reopened the PR to check the pre.commit CI. It's working properly.