search

slashmili / django-jalali

Jalali DateField support for Django model
http://pypi.python.org/pypi/django_jalali
BSD 3-Clause "New" or "Revised" License
258 stars 52 forks source link

Fix datepicker for inline admin #263

Closed mobinghoveoud closed 1 month ago

mobinghoveoud commented 1 month ago

fix #255

Description of Changes

There were two main issues with the datepicker functionality:

  1. Datepicker Executing on Inactive Inputs: In inline admin forms, the datepicker was being executed on inputs that were not yet active (those containing __prefix__ in their IDs).

  2. Reactivating Datepicker After Adding or Removing Formsets: In forms using formsets, when a new form was added or an existing one was removed, the datepicker was not reinitialized for the new inputs.

Also, changes were made to the position and look of the calendar icon and button text to match Django's style.

Testing

I tested these changes in Django versions 4.2 and 5.1. Below are screenshots showing the updated datepicker in both tabular and stacked inline forms.

Tabular Inline

image

Stacked Inline

image

hramezani commented 1 month ago

@slashmili I am not familiar with ccs and javascript and can't review the code. Based on the screenshots it looks good.

slashmili commented 1 month ago

Thanks @mobinghoveoud !

slashmili commented 1 month ago

Released as https://pypi.org/project/django-jalali/7.2.0/