search

slashmili / jalali-core

GNU Lesser General Public License v2.1
0 stars 0 forks source link

Adapt persiancalendar approach #3

Open slashmili opened 2 months ago

slashmili commented 2 months ago

@roozbehp (the original author of jalali functions in C) has been working on a persiancalendar_fast [1] which works correctly from 1187 to 3000 AP [2]

based on @5j9's benchmarking [3] it's indeed fast even through it wasn't optimised for that. The name "fast" is chosen for comparison to the astronomical implementation, which is quite slow. [4]

@roozbehp do you think you'll release the package in pypi or is it ok if we forked it under jalali-core ?

[1] https://github.com/roozbehp/persiancalendar/tree/main [2] https://github.com/slashmili/python-jalali/issues/152#issuecomment-2039370593 [3] https://github.com/slashmili/python-jalali/issues/152#issuecomment-2045334907 [4] https://github.com/slashmili/python-jalali/issues/152#issuecomment-2045302726

roozbehp commented 2 months ago

@roozbehp do you think you'll release the package in pypi or is it ok if we forked it under jalali-core ?

Please feel free to fork it. I don't plan to make it into production software myself and maintain it as such. It's research code for me.

After you fork it and have some mechanism to compare running time across different revisions, we can discuss various ideas about making it faster.