search

slashmili / python-jalali

Jalali calendar binding for Python based on Python's datetime module
http://pypi.python.org/pypi/jdatetime/
Other
335 stars 46 forks source link

Feature/add tomorrow #115

Closed sajjadshahi closed 2 years ago

hramezani commented 2 years ago

Thanks @sajjadshahi for this patch. I am not sure do we want to add this feature to python jalali. Also, you need to resolve the conflict and test for the patch. you need to add documentation to show how to use this feature.

BTW, I would suggest waiting for @slashmili and @farzadghanei opinion on this. If they agree to have this feature you can continue working on this.

slashmili commented 2 years ago

@sajjadshahi Thanks for spending time to prepare the PR.

While I see the value of this functionality, we are aiming to have feature parity with python's datetime and avoid adding anything extra to this package.

If this feature is not in the official python module, I'm afraid I can't accept this PR.

farzadghanei commented 2 years ago

Thanks for the patch, I agree with @slashmili , let's keep this library as compatible as possible, extra features can be added to applications by extending or wrapper libraries.