search

slashmili / python-jalali

Jalali calendar binding for Python based on Python's datetime module
http://pypi.python.org/pypi/jdatetime/
Other
343 stars 49 forks source link

Add `fromisoformat` method to `jdatetime.date` #126

Closed HamzehMahmoudi closed 2 years ago

hramezani commented 2 years ago

Thanks @HamzehMahmoudi for the patch :+1: I left some comments. Please address them. Also, please add a change log entry in CHANGELOG.md

HamzehMahmoudi commented 2 years ago

@hramezani thanks for the comments. mentioned issues fixed.

hramezani commented 2 years ago

@HamzehMahmoudi tests are failing. please check them.

HamzehMahmoudi commented 2 years ago

I forget to raise the Error :)))) Now its done

hramezani commented 2 years ago

@HamzehMahmoudi Thanks for your update. Please fix flake8 errors

hramezani commented 2 years ago

@HamzehMahmoudi I've updated the patch and also added another commit for fixing the flake8 issues.

I think it's ready to merge. let's wait for @slashmili, he may have some opinion on this. Otherwise, I will merge it in a few days.