search

slashmili / python-jalali

Jalali calendar binding for Python based on Python's datetime module
http://pypi.python.org/pypi/jdatetime/
Other
335 stars 46 forks source link

fix regex for persian month -->>the "دی" month has only 2 characters … #130

Closed javadfarah closed 1 year ago

javadfarah commented 1 year ago

fix regex for Persian month -->>the "دی" month has only 2 characters ……and the minimum of this regex group should start from 2 chars

javadfarah commented 1 year ago

fix regex for Persian month -->>the "دی" month has only 2 characters …

hramezani commented 1 year ago

Thanks @javadfarah for this patch :+1: Could you please add a test for this? You can add your test in test_strptime_handle_b_B_directive

javadfarah commented 1 year ago

@hramezani sure, Thanks for the quick reply, I already added tests and fixed pep8 violations in the test file

hramezani commented 1 year ago

Thanks @javadfarah for the update. I added a commit to include the new test cases in the existing test and revert the formating changes. we are not using black for now. Now it look good.

hramezani commented 1 year ago

Changelog added!