search

slashmili / python-jalali

Jalali calendar binding for Python based on Python's datetime module
http://pypi.python.org/pypi/jdatetime/
Other
335 stars 46 forks source link

tests(test_zoneinfo_as_timezone): skip if tzinfo is not available on … #135

Closed 5j9 closed 1 year ago

5j9 commented 1 year ago

…windows

On Windows, zoneinfo relies on tzinfo and without it the tests fail with import error.

Also, rewrite pickle file loading. Previously open was using a relative path, which means the path used to depend on the current working directory and could fail if tests were triggered from a wrong directory. The new load_pickle function will handle that.

slashmili commented 1 year ago

@5j9 / @hramezani do you know how to fix the build in windows? https://ci.appveyor.com/project/slashmili/python-jalali

If we want to apply this changes, I'd rather to fix the appveyor as well.

5j9 commented 1 year ago

@slashmili I just triggered an Appveyor build for this commit and it worked fine: https://ci.appveyor.com/project/5j9/python-jalali

I read somewhere that this particular error may occur if Appveyor's authorization to read your Github account has expired. You may need to revoke the Github access by going to https://ci.appveyor.com/authorizations and then reauthorize it.

slashmili commented 1 year ago

Thanks @5j9! It was indeed authorization issue!