Fixes and Improvments - Githubissues

pouyamn commented 5 years ago

Fixes '12:mm:ss am' display problem in strftime
- In 12 hour time, there is no hour 00, day begins with 12:00am after midnight.
Adds support for '%-I' format token which were missed before
Fixes '%X' token in strftime:
- it should return 'HH:MM:SS' format but it returns 'HH:II:SS'!
Fixes Week of year, currently it starts with zero and increases every 7 days, ignoring weekdays
- In Jalali Calendar, The first week of year is the week containing 1st of Farvardin and this week can be less than 7 days. So calculating week of year by dividing day-of-year by 7 was incorrect. For example, if 1st of Farvardin is Thursday, 3rd of Farvardin is Saturday and should be in week 2, but the code shows week 0. Well another point is that in Jalali calendar (and any other calendar that I have seen) week numbers start at 1 not 0.
Refactor: weekday was rewritten to avoid having lot's of if cases.

slashmili commented 5 years ago

Pushed as 3.5.0

slashmili commented 5 years ago

Thanks @pouyamn 🎉

Plz update your master if you are going to continue your awesome work on this library!

slashmili / python-jalali