search

slashmo / gsoc-swift-tracing

WIP collection of Swift libraries enabling Tracing on Swift (Server) systems.
https://summerofcode.withgoogle.com/projects/#6092707967008768
Apache License 2.0
20 stars 1 forks source link

Fix NIO & HTTP Client version clash in UseCases 📦 #109

Closed slashmo closed 4 years ago

slashmo commented 4 years ago

Having both NIO & AsyncHTTPClient as explicit dependencies made the resolution fail.

slashmo commented 4 years ago

E.g. here: https://github.com/slashmo/gsoc-swift-tracing/runs/945048329?check_suite_focus=true

ktoso commented 4 years ago

That's very weird... I've asked the team for feedback why the error message is bad like that:

Fetching https://github.com/slashmo/gsoc-swift-baggage-context
Fetching https://github.com/apple/swift-nio.git
Fetching https://github.com/apple/swift-nio-ssl.git
Fetching https://github.com/apple/swift-log.git
error: Failed to clone https://github.com/apple/swift-nio.git:
    Cloning into bare repository '/__w/gsoc-swift-tracing/gsoc-swift-tracing/UseCases/.build/repositories/swift-nio-b68c973e'...
    fatal: unable to access 'https://github.com/apple/swift-nio.git/': transfer closed with outstanding read data remaining
Fetching https://github.com/apple/swift-nio-extras.git
##[error]Process completed with exit code 1.

While it seems more like it should be a version conflict?

ktoso commented 4 years ago

I could not reproduce the dependency error...?

Can you confirm this happened also locally? (I'm trying to report this to the SPM team but we can't reproduce)

ktoso commented 4 years ago

Looking at it again... fatal: unable to access 'https://github.com/apple/swift-nio.git/': transfer closed with outstanding read data remaining makes me realize perhaps it was just github having some hiccups 🤔