slashmo / gsoc-swift-tracing

WIP collection of Swift libraries enabling Tracing on Swift (Server) systems.
https://summerofcode.withgoogle.com/projects/#6092707967008768
Apache License 2.0
20 stars 1 forks source link

Add recordError method to Span #111

Closed slashmo closed 4 years ago

slashmo commented 4 years ago

Adds recordError(type:String?,message:String?) to Span with default implementation to record errors as SpanEvents.

Closes #90

ktoso commented 4 years ago

It would be actually interesting to ask on the opentelemetry spec, you could ask there for advice what we should do -- Error in swift are just values, we do not have stacktraces for them and generally they're called errors -- should we anyway record them as exceptions for nicer interop with the rest of the ecosystem?