search

slashmo / gsoc-swift-tracing

WIP collection of Swift libraries enabling Tracing on Swift (Server) systems.
https://summerofcode.withgoogle.com/projects/#6092707967008768
Apache License 2.0
20 stars 1 forks source link

Return nil when extracting empty header value #147

Closed slashmo closed 4 years ago

slashmo commented 4 years ago

Due to the changes introduced in #146, when HTTPHeadersExtractor extracts no headers, it returns an empty string instead of nil, which may lead to slight misbehavior for users of this API.

ktoso commented 4 years ago

Oh great catch! LGTM