search

slashmo / jaeger-client-swift

Jaeger Client built for Swift Distributed Tracing
Apache License 2.0
9 stars 0 forks source link

Add Sampler protocol & ConstantSampler conformance #7

Closed slashmo closed 3 years ago

slashmo commented 3 years ago

This PR lays the foundation for sampling. It adds a Sampler protocol with the simplest of conformances, the ConstantSampler. Other than that, it's now JaegerTracers responsibility to update the TraceContext of a span it's starting. Therefore, the JaegerSpan initializer becomes simpler and assigns arguments to stored properties.

Closes #2

slashmo commented 3 years ago

This looks good! LGTM 👍 @ktoso

Thanks for the review 👌