"Closing an Inventory" Feature

slashroots / undp-ghg-v2

Node JS version of the UNDP Greenhouse Gases Database

0 stars 0 forks source link

"Closing an Inventory" Feature #64

Closed paradoxxjm closed 6 years ago

paradoxxjm commented 6 years ago

Currently, the application does not allow an inventory manager or admin user to "close" an inventory. A few design considerations that need to be fulfilled for this feature

Closing an inventory should prevent further changes (e.g modifications to settings, data table, calculations, etc,) by all users.
Only an Inventory Manager or Administrator should be able to re-open an inventory
Administrators / Inventory Managers should be allowed to open only one inventory at a time.

@matjames007 Denique, please confirm what other constraints need to be included.

matjames007 commented 6 years ago

@paradoxxjm this actually exists currently - however the error messaging in the platform requires some work.

densoutar commented 6 years ago

Noted @matjames007; but for the record, other constraints:

Closed inventories should be visibly tagged as closed in the Data, Calculations and Reporting pages.
Attempt to re-openan inventory should be confirmed.

paradoxxjm commented 6 years ago

@denferg can you confirm.

densoutar commented 6 years ago

Partially resolved. Resolved issues are:

Only admin and manager roles have option to close inventory
Attempt to close inventory triggers confirmation

Unable to test the following (not sure if closing the inventory would interfere with troubleshooting other issues currently waiting to be addressed):

ability to edit a closed inventory
whether closed inventory is tagged as closed
whether only an inventory manager or admin can re-open, after confirmation

@gilgad

densoutar commented 6 years ago

@gilgad confirmed it should not be possible to re-open an inventory after an inventory is closed. If values need to be updated, that will be done in the next inventory.

Will consider this issue resolved.