search

slashroots / undp-ghg-v2

Node JS version of the UNDP Greenhouse Gases Database
0 stars 0 forks source link

Inconsistent display of significant figures #65

Closed densoutar closed 6 years ago

densoutar commented 6 years ago

Numbers should be displayed according to the same formats (the IPPC has requirements for significant figures). The Calculations page for example displays both rounded off figures and figures to a number of decimal places, making checking calculations confusing.

screen shot 2018-02-15 at 9 46 59 pm
paradoxxjm commented 6 years ago

@denferg can you provide more specifics as to how you would like @gilgad to modify the precision level for the numbers.

densoutar commented 6 years ago

The Calculations AD value is rounded off to far fewer significant figures than all the other values on the Calculations screen.

It appears one standard of rounding is applied to the AD variable values in Data, another to the AD variable values in Calculation, and a third standard to the AD variable actually used in the computation.

There needs to be one standard for how numbers are displayed and computed, and that needs to be based on the specifications in the IPCC Guidelines (I believe Budram had said this was a thing...at the very least, there is some standard he's using).

densoutar commented 6 years ago

Unable to test, as AD values are no longer displayed (see comments on #69).

densoutar commented 6 years ago

AD values displayed are consistent with the values used for calculation; marked as pass.