search

slateci / slate-catalog

SLATE application catalog based on Helm
12 stars 21 forks source link

(not urgent) Formatting pass #575

Open LincolnBryant opened 2 years ago

LincolnBryant commented 2 years ago

This does a formatting pass across the squid chart to properly align comments and will chomp extraneous newlines, so the output via helm template looks much cleaner.

E.g., before:

kind: Service
apiVersion: v1
metadata:
  name: osg-frontier-squid
  labels:
    app: osg-frontier-squid
    release: RELEASE-NAME
    instance: ""
spec:
  type: NodePort

  externalTrafficPolicy: Local

  selector:
    app: osg-frontier-squid
    release: RELEASE-NAME
    instance: ""
  ports:
  - port: 3128
    name: cache
    targetPort: squid

  - port: 3401
    name: monitoring
    targetPort: monitoring
    protocol: UDP

After:

kind: Service
apiVersion: v1
metadata:
  name: osg-frontier-squid
  labels:
    app: osg-frontier-squid
    release: RELEASE-NAME
    instance: ""
spec:
  type: NodePort
  externalTrafficPolicy: Local
  selector:
    app: osg-frontier-squid
    release: RELEASE-NAME
    instance: ""
  ports:
  - port: 3128
    name: cache
    targetPort: squid
  - port: 3401
    name: monitoring
    targetPort: monitoring
    protocol: UDP
adamhgriffith-uofu commented 2 years ago

Checking in on the status of this work.