slatex / LaTeXML-Plugin-sTeX

A LaTeXML Plugin for Semantic LaTeX (sTeX)
LaTeX Project Public License v1.3c
2 stars 3 forks source link

Replaced missing LaTeXML::Core::Definition::Expandable::substituteTokens by substituteParameters. #120

Closed dominique-unruh closed 5 years ago

dominique-unruh commented 5 years ago

I am guessing that this is the right thing, at least it removes an error in my test document successfully:

\documentclass{omdoc}

\usepackage{modules}
\usepackage{cmath}

\begin{document}

\begin{module}[id=test]
  \symdef{test}[1]{\mathsf{Test}[#1]}

  $\test 1$
\end{module}

\end{document}
dginev commented 5 years ago

Looks correct, nice patch! You should also be able to remove the outer Tokens() wrapper, which is no longer necessary in the new call, as it is auto-generated.

The commit that refactored the latexml API is here for reference: https://github.com/brucemiller/LaTeXML/commit/999e3d625382fcc94de73eb65da1e5f2690991d0

kohlhase commented 5 years ago

Deyan, I am assuming you will take care of this; right?

dginev commented 5 years ago

Oh, certainly, was just waiting to see if anything else comes up.