slauger / check_netscaler

A Nagios Plugin written in Perl for the Citrix ADC (formerly Citrix NetScaler). It uses the NetScaler NITRO API.
36 stars 18 forks source link

Support Multiline output #28

Open cstegm opened 6 years ago

cstegm commented 6 years ago

Hi,

i like this plugin! It would be nice if we can have a multiline output (activated by an option).

slauger commented 6 years ago

Hi,

thanks for your feedback!

Could you give me an example? How do you want the plugin output to look like?

I can implement a dymamic line seperator (for example „\n“) for each call of $plugin->add_message(), instead of the currently hardcoded semicolon if that is what you want.

Cheers, Simon

cstegm commented 6 years ago

Hi,

I guess I have a nice example:

NetScaler OK - state servicegroup: GRUPPE_SERVICEGROUP1 UP: GRUPPE_SERVICEGROUP_2 UP: GRUPPE_SERVICEGROUP_3 UP: GRUPPE_SERVICEGROUP_4 UP: GRUPPE_SERVICEGROUP_5 UP: GRUPPE_SERVICEGROUP_6 UP: GRUPPE_SERVICEGROUP_7 UP: GRUPPE_SERVICEGROUP_8 UP: GRUPPE_SERVICEGROUP_9 UP: GRUPPE_SERVICEGROUP_10 UP: GRUPPE_SERVICEGROUP_11 DOWN: 0 UNKOWN: 0 PARTIAL-UP: 10 UP: 0 OUT OF SERVICE: 1 DOWN:

Ideal would be:

NetScaler 'servicegroup' OK

servicegroup(s):
[OK] GRUPPE_SERVICEGROUP1 UP
[OK] GRUPPE_SERVICEGROUP_2 UP
[OK] GRUPPE_SERVICEGROUP_3 UP
[OK] GRUPPE_SERVICEGROUP_4 UP
[OK] GRUPPE_SERVICEGROUP_5 UP
[OK] GRUPPE_SERVICEGROUP_6 UP
[OK] GRUPPE_SERVICEGROUP_7 UP
[OK] GRUPPE_SERVICEGROUP_8 UP
[OK] GRUPPE_SERVICEGROUP_9 UP
[OK] GRUPPE_SERVICEGROUP_10 UP
[CRITICAL] GRUPPE_SERVICEGROUP_11 DOWN

UNKOWN:           0
PARTIAL-UP:       0
UP:              10
OUT OF SERVICE:   0
DOWN:             1

Some Details We Use Icingaweb2 - In a service overview or list view we see a the short output which is alway the first Line of the plugin Output: NetScaler 'servicegroup' OK

In Icingaweb2 an occurance in the pluginoutput of [OK], [WARNING] or [CRITICAL] is automatically colored green, orange and red - so you see directly the issue that we detect with that check. ( Example of the Coloring https://cloud.githubusercontent.com/assets/25796110/25178084/bc486c4a-2504-11e7-889e-64c66559e52d.png )

bb-Ricardo commented 6 years ago

+1

Maybe I got some time in the near future to add this. Important would be to output the CRITICAL/WARNING $SERVICE at the first line.