rename reusable splits (suggest array when duplicate key detected in names)

slaurent22 / hk-split-maker

HK Split Maker

https://hksplitmaker.com/

17 stars 21 forks source link

rename reusable splits (suggest array when duplicate key detected in names) #35

Closed cerpintext closed 3 years ago

cerpintext commented 3 years ago

while setting up 106% splits to PR, I encountered a bug where I couldn't rename two different instances of the same transition autosplit to reflect the different points in the route they represent, leading to less immediately understandable splits.

Example of how the naming was written, and the error message:

  "names": {
    "EnterAnyDream": "Tyrant Dream Entry",

    "EnterAnyDream": "[2d] FC Dream Entry",

cerpintext commented 3 years ago

this duplicate error resulted in only the second given name being used for both instances of "EnterAnyDream", as shown quick here in the output file:

slaurent22 commented 3 years ago

Use an array of names, like the flame splits in https://hksplitmaker.com/#NKG_flame_splits

cerpintext commented 3 years ago

add this to the error message/suggested solution when duplicate keys in names? 👀

slaurent22 commented 3 years ago

add this to the error message/suggested solution when duplicate keys in names? 👀

I don't know if this is possible at the schema level, but doing it after clicking "Generate" might work with something like https://www.npmjs.com/package/json-duplicate-key-handle

slaurent22 commented 3 years ago

Closing due to not having an action item