nesquena
commented
10 years ago :+1: nice work. A few notes after checking out the code:
- Properly reused the single method to fetch results for both initial load and the pagination
- Properly used spinners (with populated values) to allow users to select filters
- Great use of an IntentService to execute the query
- Good to see you used a filters object to represent the filters to apply to the query
- Nice job adding the share intent to the image detail view!
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
To your questions:
I had trouble adding action bar button for settings. I wasn't able to make it visible in action bar on my device, since it has a hardware menu button. I could make it visible using compatibility library, but I'd continuously get crash when starting activity for result. Would be awesome to get some advice on backward compatibility and android support library/AppCompat theme.
Yes, if you have a hardware button makes sense to use the compatibility library support v7. In particular using the ActionBarActivity as described here. This post does a decent job explaining how to set it up and configure proper theme. Let me know if there's anything else you need to know.
I wonder what would be the best strategy to pass search results to activity. Using temp was pretty straightforward, but probably not optimal solution. I'd probably go for SQLite database.
Yes, we could certainly use persistence. We will be discussing persistence strategies and options in detail in tomorrow's lecture.
It would be good to know a few different strategies to make GridView look nicer. Now it flickers and resizes itself every time the image is loaded. Frankly speaking, looks pretty nasty.
Agreed, it does look nasty by default. Thankfully pretty easy to fix with a few tweaks. See here and here for specifics.
Actually, share action controller also brought me a little pain, since it was crashing multiple times when I was trying to acquire image url or ShareActionProvider itself.
The share an image cliffnotes might help if you haven't seen them yet?
What about conventions/coding style/guidelines? I think it's quite important to teach people how to write clean, beautiful, consistent and easy to read code. What's your opinion on that?
I agree with you 100% about these being very important. I encourage every student towards later weeks to read through the official style guide and be sure to setup the android eclipse formatter
Hi Nathan,
please find the ImageSearch project in the corresponding folder. Couple of issues I encountered:
Thanks a lot again. Looking forward to your feedback.