slavkoder / code-path-android

Repository for CodePath Android bootcamp projects and homeworks. Learn more at http://thecodepath.com/
0 stars 0 forks source link

[Android Bootcamp] TwitterClient - Review my homework #4

Open slavkoder opened 10 years ago

slavkoder commented 10 years ago

Hi Nathan,

sorry to bother you again. I pretty much implemented the app based on my local tweets, but I think there is a minor mistake somewhere for the actual API. I'm now finally getting on the road, but I'll be online around midnight. I'd like to take a closer look into oauth stack and how it works actually. Talk to you later.

Thanks a lot for your patience and commitment.

nesquena commented 10 years ago

:+1: nice work overall. A few notes after checking out the code:

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together. We are close to a turning point in the course where you should be hitting a "critical mass" for your Android knowledge.

There are couple of things that I didn't implement:

  • Offline mode with sql persistence;

Yes, you should definitely try this next week (4th project is actually extending twitter)

  • Progress bar (actually I'd like to try making a spinning progress indicator in the action bar);

Cool, see progress clifffnotes explains how to do that

  • On the compose screen it would be cool to copy official client by moving character counter text view into action bar, it should be easy;

Great idea, easy to do. Check out extending ActionBar guide for more details.

I'd like to look closer into your oauth client code and implement my own client using Retrofit, for instance.

I think that's a great idea.