slavniyteo
commented
6 years ago Thank you for this case. It is similar to #13 with a difference in one detail: [Range] is not a CustomPropertyDrawer.
Right now OneLine doesn't draw custom property drawers but it is the next task in my TODO list.
But you can add this behaviour very simply here.
private void DrawProperty(Rect rect, SerializedProperty property){
bool isCustomPropertyDrawer = IsThisPropertyMustBeDrawnWithYourPropertyDrawer(property);
if (isCustomPropertyDrawer){
EditorGUI.PropertyField(rect, property, GUIContent.none);
}
else {
typeof(EditorGUI)
.GetMethod("DefaultPropertyField", BindingFlags.NonPublic | BindingFlags.Static)
.Invoke(null, new object[]{rect, property, GUIContent.none});
}
}It will draw your fields in whole cycle (with all decorators and custom drawers). But see at the comment here
/*
- WORKAROUND
- Unity3d
feature: EditorGUI.PropertyField draws field- with all decorators (like Header, Space, etc) and this behaviour
- can not be ommited.
- see: http://answers.unity3d.com/questions/1394991/how-to-preserve-drawing-decoratordrawer-like-heade.html
- Headers and Separators (provided by one-line) produces artefacts.
- We solve this problem with reflection, but we call internal method
- and this may be dangerous: unity3d developers may change API =( */
So whole drawing cycle produces some artifacts with property decorators like [Header] or [Space].
You can avoid it with drawing this way:
private void DrawProperty(Rect rect, SerializedProperty property){
bool isCustomPropertyDrawer = IsThisPropertyMustBeDrawnWithYourPropertyDrawer(property);
if (isCustomPropertyDrawer){
// EditorGUI.PropertyField(rect, property, GUIContent.none);
var drawer = new YourCustomPropertyDrawer(); // Cache it, pleace
drawer.OnGUI(rect, property, GUIContent.none);
}
else {
typeof(EditorGUI)
.GetMethod("DefaultPropertyField", BindingFlags.NonPublic | BindingFlags.Static)
.Invoke(null, new object[]{rect, property, GUIContent.none});
}
}Sorry, I can't check the code above, so it is just a pseudocode =)
I wish it is useful for you.
KonH
I'm interested in using your utility, but found one issue and now don't know can it be resolved in basics. In my project unity3d-class-type-reference is used like this:
In standard cases ClassTypeReference instance is shown as drop-down, which allow you to select class with given constraints. ClassTypeReference used their own CustomPropertyDrawer to do it.
Problem is here: when [OneLine] attribute is used on Nodes it shown as just editable string, which is not properly usable.
It is any proposals how this issue can be resolved with/without changes in utility code?