slavomir-sidor / vopenlayers

Automatically exported from code.google.com/p/vopenlayers
0 stars 0 forks source link

WebMapServiceLayer: add support for singleTile option #105

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
org.vaadin.vol.WebMapServiceLayer should offer a way to set the singleTile 
option of a WMS layer (see http://openlayers.org/dev/examples/single-tile.html).

This is quite a simple feature to add, see the attached patch file.

Original issue reported on code.google.com by tgor...@gmail.com on 5 Nov 2012 at 4:27

Attachments:

GoogleCodeExporter commented 9 years ago
Hi,
thank you for the patch :-)
I just want to take a look on your patch but unfortunately the diff format 
brings me in trouble on my system (can't handle the paths). Please create the 
patch like this
 ...

1. update your current working copy
2. insert  your changes here
3. change to the root of your working copy ... cd vopenlayers-read-only
4. svn diff > my_new_patch.diff

If you send me a patch created in the described way I will check it. You can 
speed  up the check if you add a little test to the demo in the add on project. 
Take a look at the demo package (for instance 
org.vaadin.vol.demo.WebFeatureServiceLayerTest). It's a good and not to 
complicated example :-D

Kind regards,
Eiko

@matti I hope it's in your mind? You seem very busy these days.

Original comment by eiko.tho...@gmail.com on 6 Nov 2012 at 8:40

GoogleCodeExporter commented 9 years ago
Thanks for your quick reponse. I'm sending you the patch in SVN format. The 
diff file is in french (vive la révision), but that shouldn't be a problem, no?

Original comment by tgor...@gmail.com on 8 Nov 2012 at 8:02

Attachments:

GoogleCodeExporter commented 9 years ago
I have committed your changes to r185. Thank you :-)

Kind regards,
Eiko

Original comment by eiko.tho...@gmail.com on 12 Nov 2012 at 8:17

GoogleCodeExporter commented 9 years ago

Original comment by eiko.tho...@gmail.com on 12 Nov 2012 at 8:18

GoogleCodeExporter commented 9 years ago
Thanks, Eiko!

Original comment by tgor...@gmail.com on 12 Nov 2012 at 12:39