slawkens / myaac

A free and open-source Automatic Account Creator (AAC) written in PHP
https://my-aac.org
GNU General Public License v3.0
125 stars 99 forks source link

TFS Webservice #180

Closed omarcopires closed 2 years ago

omarcopires commented 2 years ago

Well, as everyone already knows, support for protocol 12.72 was added to TFS, with that came the need to add login.php to be able to connect to the server and currently MYAAC doesn't have this plugin, anyway I'm trying to work on it to make connection, but still not successful. Here's the code base I've been working on: https://gist.github.com/omarcopires/b5bfa3febd5a7f4601fc08dd84597843

I believe the problem is sessionkey related.

lgrossi commented 2 years ago

https://github.com/opentibiabr/login-server 😘

slawkens commented 2 years ago

https://github.com/opentibiabr/login-server 😘

So, what's the point? Trolling.

topic

Did you test the version from otservbr team? There was some repo they had with myaac login plugin for version 12.x, maybe it works with tfs 12.x too? I'm currently unable to test.

omarcopires commented 2 years ago

@slawkens the login that I put in for example is basically the same as theirs, with the exception that boosted, events and the premium system were removed, which was also custom. I changed the tables to be compatible with tfs, but I still couldn't connect, not even using the login without edits. As said, I believe it's something related to sessionkey, well, we can see an example of the changes here: https://github.com/Znote/ZnoteAAC/pull/493

gpedro commented 2 years ago

well, idk about that issue... but opentibiabr already made a plugin for tibia12 https://github.com/opentibiabr/myaac-tibia12-login

it's the most used plugin for myaac https://my-aac.org/charts/

--

there are not many changes, opentibiabr looks better than yours, but you can feel free to make a pull request to make some compatibility, like table and column existence, two-factor authentication and etc.

slawkens commented 2 years ago

I am unsure if login service should be part of AAC, that's the first thing.

Second, the plugins always existed as @gpedro pointed.

So I'm closing this now, because discussion is useless.

slawkens commented 2 years ago

Thanks for closing, feel free to reopen if you have any further questions.