slawlor / ractor

Rust actor framework
MIT License
1.31k stars 68 forks source link

Add rt+macro features to tokio dep to fix build #119

Closed jsgf closed 1 year ago

jsgf commented 1 year ago

Without this non-dev builds (ie dependencies) fail:

error[E0432]: unresolved import `tokio_primatives`
   --> /home/jeremy/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ractor-0.8.4/src/concurrency.rs:139:9
    |
139 | pub use tokio_primatives::*;
    |         ^^^^^^^^^^^^^^^^ use of undeclared crate or module `tokio_primatives`

error[E0432]: unresolved imports `crate::concurrency::JoinHandle`, `crate::concurrency::MpscReceiver`, `crate::concurrency::MpscUnboundedReceiver`, `crate::concurrency::MpscReceiver`, `crate::concurrency::MpscSender`, `crate::concurrency::MpscUnboundedReceiver`, `crate::concurrency::MpscUnboundedSender`
  --> /home/jeremy/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ractor-0.8.4/src/actor/mod.rs:16:5
   |
16 | use crate::concurrency::JoinHandle;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `JoinHandle` in `concurrency`
   |
[...]
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (c98cd1c) 79.93% compared to head (82d301b) 79.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #119 +/- ## ======================================= Coverage 79.93% 79.93% ======================================= Files 50 50 Lines 8863 8863 ======================================= Hits 7085 7085 Misses 1778 1778 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/slawlor/ractor/pull/119/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

slawlor commented 1 year ago

@jsgf what are you running in this build? I checked both dev and release builds, and everything looks fine to me...