slawlor / ractor

Rust actor framework
MIT License
1.31k stars 68 forks source link

Add the optional name of the actor to the tracing span and code-re-organization #135

Closed slawlor closed 11 months ago

slawlor commented 11 months ago

Adds the actor's name to the tracing span if its specified for easier log-grepping

RE: code re-org

This should be a functional no-op, but has been on my backlog for a bit. I'm re-organizing unnecessary sub-folders and whatnot into a flatter structure that makes logically more sense.

All re-exported types are the same, but the original definition of many things have changed so most users should se no difference, but it may cause some advanced cases to need to adjust imports/usages.

For reviewer:

It's probably best to review this in commit-order. The first commit is the tracing change, then the code re-org.

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 82.60% and project coverage change: +0.01% :tada:

Comparison is base (9b21448) 79.16% compared to head (3fac3e7) 79.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #135 +/- ## ========================================== + Coverage 79.16% 79.18% +0.01% ========================================== Files 49 48 -1 Lines 8890 8898 +8 ========================================== + Hits 7038 7046 +8 Misses 1852 1852 ``` | [Files Changed](https://app.codecov.io/gh/slawlor/ractor/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor) | Coverage Δ | | |---|---|---| | [ractor/src/actor/actor\_id.rs](https://app.codecov.io/gh/slawlor/ractor/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor#diff-cmFjdG9yL3NyYy9hY3Rvci9hY3Rvcl9pZC5ycw==) | `100.00% <ø> (ø)` | | | [ractor/src/actor/messages.rs](https://app.codecov.io/gh/slawlor/ractor/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor#diff-cmFjdG9yL3NyYy9hY3Rvci9tZXNzYWdlcy5ycw==) | `69.64% <ø> (ø)` | | | [ractor/src/errors.rs](https://app.codecov.io/gh/slawlor/ractor/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor#diff-cmFjdG9yL3NyYy9lcnJvcnMucnM=) | `63.63% <78.57%> (ø)` | | | [ractor/src/actor/actor\_cell.rs](https://app.codecov.io/gh/slawlor/ractor/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor#diff-cmFjdG9yL3NyYy9hY3Rvci9hY3Rvcl9jZWxsLnJz) | `94.68% <100.00%> (ø)` | | | [ractor/src/actor/actor\_properties.rs](https://app.codecov.io/gh/slawlor/ractor/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor#diff-cmFjdG9yL3NyYy9hY3Rvci9hY3Rvcl9wcm9wZXJ0aWVzLnJz) | `99.20% <100.00%> (ø)` | | | [ractor/src/actor/actor\_ref.rs](https://app.codecov.io/gh/slawlor/ractor/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor#diff-cmFjdG9yL3NyYy9hY3Rvci9hY3Rvcl9yZWYucnM=) | `86.11% <100.00%> (ø)` | | | [ractor/src/actor/mod.rs](https://app.codecov.io/gh/slawlor/ractor/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor#diff-cmFjdG9yL3NyYy9hY3Rvci9tb2QucnM=) | `88.53% <100.00%> (+0.18%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/slawlor/ractor/pull/135/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.