Open nolmelab opened 1 year ago
fn build_protobufs() {
// std::env::set_var("PROTOC", protobuf_src::protoc());
std::env::set_var("PROTOC", "D:/App/protoc-24.2-win64/bin/protoc.exe");
...
}
Setting protoc.exe to the downloaded folder made the ractor crate build success on windows. I think this can be optional for windows.
I'll try and look into it, sounds like a bug for Windows. Thanks for reporting.
Any suggestion to solve/bypass the problem?
The latest version of protobuf-src now builds with CMake rather than autotools. I've not yet tested this, but it may "just work" with Windows now.
Description of the problem encountered
I tried to build examples with ractor and ractor_cluster on windows 10 machine and encountered following error:
autotools requires configure & make, which are not available on windows by default.
Describe the solution you'd like I tried to remove dependency on protobuf-src in ractor repository by removing protobuf-src line in ractor_cluster/Cargo.toml and std::env::set_var("PROTOC", ... ) line in build.rs file.
Then the build complains about missing google.protobuf.Timestamp and some other files while compiling *.proto files. (I made protoc.exe available via PATH env variable)
If ractor_cluster requires some of the .proto files from protobuf and protoc only, then I think the dependency on protobuf-src can be removed.
It will make using ractor_cluster on windows really simple.
Describe alternatives you've considered I also consider that dependency on protobuf can be removed entirely using rust serialization (binary or json) in platform compatible way. Then it can make building and using ractor_cluster easier than now still supporting (possibly) other languages and platforms.
Additional context