codecov[bot]
commented
8 months ago Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.
Comparison is base (
c1bce01) 79.49% compared to head (a46aadd) 79.64%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #182 +/- ## ========================================== + Coverage 79.49% 79.64% +0.15% ========================================== Files 50 50 Lines 9671 9708 +37 ========================================== + Hits 7688 7732 +44 + Misses 1983 1976 -7 ``` | [Files](https://app.codecov.io/gh/slawlor/ractor/pull/182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor) | Coverage Δ | | |---|---|---| | [ractor/src/pg/tests.rs](https://app.codecov.io/gh/slawlor/ractor/pull/182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor#diff-cmFjdG9yL3NyYy9wZy90ZXN0cy5ycw==) | `93.59% <94.28%> (+0.06%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/slawlor/ractor/pull/182/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sean+Lawlor):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR adds the crate serial_test to the dev dependencies as suggested in https://github.com/slawlor/ractor/pull/177#discussion_r1390216399. Based on its functionality, it:
which_scopes_and_groupstest, andtest_pg_monitoringtest_scope_monitoring-- Curiously, my tests pass when I don't add the
#[serial]macro to either (but not both) of the monitoring tests. Maybe theirActorimplementations forNotificationMonitorclash, but my mental model of how this works isn't complete enough yet to figure that one out.