Closed leonqadirie closed 6 months ago
Attention: 8 lines
in your changes are missing coverage. Please review.
Comparison is base (
c1bce01
) 79.49% compared to head (f63ccf9
) 79.72%. Report is 2 commits behind head on main.:exclamation: Current head f63ccf9 differs from pull request most recent head 70e033a. Consider uploading reports for the commit 70e033a to get more accurate results
Files | Patch % | Lines |
---|---|---|
ractor/src/actor/tests/mod.rs | 89.13% | 5 Missing :warning: |
ractor/src/pg/tests.rs | 95.00% | 2 Missing :warning: |
ractor/src/pg/mod.rs | 96.42% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Sorry I messed up my Git history here. Will reopen a hopefully cleaner PR...
Introduces an
index
field to thePgState
struct to mapScopeName
toVec<GroupName>
.If this isn't what was in mind, I'd need another pointer :) Would also be open to refactoring the index's value and the modules
Vec<...>
-method returns toHashSet
s if that makes more sense.-- Relating to https://github.com/slawlor/ractor/pull/177#discussion_r1363016547
and https://github.com/slawlor/ractor/issues/184#issuecomment-1846273238